Add new initial fields to v20240812preview #3478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimorris27
force-pushed
the
new-api-fields
branch
3 times, most recently
from
e9bba91
to
e4348ee
Compare
cadenmarchese
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
jharrington22,
cblecker,
UlrichSchlueter,
s-amann,
SudoBrendan,
Shivkumar13,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
dofinn and
tiguelu
as code owners
cadenmarchese
added
ready-for-review
chainsaw
|
/azp run ci,e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
kimorris27
requested changes
Mar 25, 2024
kimorris27
force-pushed
the
new-api-fields
branch
from
e4348ee
to
47e9a0d
Compare
|
/azp run ci,e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
kimorris27
requested changes
Mar 29, 2024
kimorris27
previously approved these changes
Mar 29, 2024
|
/azp run ci, e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
tsatam
previously approved these changes
Apr 1, 2024
s-amann
previously approved these changes
Apr 2, 2024
cadenmarchese
dismissed stale reviews from s-amann, tsatam, and kimorris27
via
0016940
|
@s-amann should be good now, thanks for pointing that out! |
kimorris27
approved these changes
Apr 4, 2024
kimorris27
requested changes
Apr 4, 2024
- Added missing JSON tags - Added missing readOnly Swagger tags - Removed extra whitespace from comment
kimorris27
force-pushed
the
new-api-fields
branch
from
335429e
to
d888609
Compare
|
/azp run ci,e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
tsatam
approved these changes
Apr 8, 2024
s-amann
approved these changes
Apr 8, 2024
kimorris27
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes https://issues.redhat.com/browse/ARO-4381 && https://issues.redhat.com/browse/ARO-4377, unblocks https://issues.redhat.com/browse/ARO-3979
What this PR does / why we need it:
This is the first of 3-ish PRs to add new fields to the preview API + converter. There will be additional fields added to support OCP upgrades as well as Cluster MSI.
Test plan for issue:
Is there any documentation that needs to be updated for this PR?
How do you know this will function as expected in production?